Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding option for FM90_B3 to FM99_method #246

Merged
merged 2 commits into from
Dec 31, 2024
Merged

adding option for FM90_B3 to FM99_method #246

merged 2 commits into from
Dec 31, 2024

Conversation

karllark
Copy link
Owner

Useful for measure_extinction.modeldata. Allows fitting for the amplitude of the 2175 A bump (B3) instead of the "strength" C3.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.55%. Comparing base (9b47a49) to head (bc6e1bf).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
dust_extinction/shapes.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   99.66%   99.55%   -0.12%     
==========================================
  Files           9        9              
  Lines         899      901       +2     
==========================================
+ Hits          896      897       +1     
- Misses          3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karllark karllark merged commit cc59bd6 into master Dec 31, 2024
30 of 32 checks passed
@karllark karllark deleted the b3_fm90_method branch December 31, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant